chia7712 commented on code in PR #20380:
URL: https://github.com/apache/kafka/pull/20380#discussion_r2340530268
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java:
##########
@@ -304,9 +304,9 @@ public void reset() throws IOException {
/**
* Get offset relative to base offset of this index
- * @throws IndexOffsetOverflowException
+ @throws IndexOffsetOverflowException if the OptionalInt is empty
*/
- public int relativeOffset(long offset) {
+ public int relativeOffset(long offset) throws IndexOffsetOverflowException
{
Review Comment:
The unchecked exception is already documented, so we probably don't need to
include it in the method signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
