apoorvmittal10 commented on code in PR #20246:
URL: https://github.com/apache/kafka/pull/20246#discussion_r2351769359
##########
clients/src/main/resources/common/message/ShareFetchRequest.json:
##########
@@ -32,6 +33,8 @@
"about": "The current share session epoch: 0 to open a share session; -1
to close it; otherwise increments for consecutive requests." },
{ "name": "MaxWaitMs", "type": "int32", "versions": "0+",
"about": "The maximum time in milliseconds to wait for the response." },
+ { "name": "AcquireMode", "type": "string", "versions": "2+",
+ "about": "The acquire mode to control max fetch records behavior" },
Review Comment:
Shall we please remove client side changes from the PR and let's have only
server side changes as that not requires a KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
