AndrewJSchofield commented on code in PR #20479:
URL: https://github.com/apache/kafka/pull/20479#discussion_r2353154381
##########
docker/examples/README.md:
##########
@@ -147,7 +147,8 @@ Single Node
- To produce messages using client scripts (Ensure that java version >=
17):
```
# Run from root of the repo
- $ bin/kafka-console-producer.sh --topic test --bootstrap-server
localhost:9093 --producer.config
./docker/examples/fixtures/client-secrets/client-ssl.properties
+ # Note: In Kafka 4.2+, --command-config replaces the deprecated
--producer.config option.
Review Comment:
I would not document this here. It's in a code comment inside a code block
intended to go into a shell. So, either just replace the argument name in the
command, or move the deprecation text up into line 147. I suggest the former.
##########
docker/examples/README.md:
##########
@@ -167,7 +168,8 @@ Single Node
- To produce messages using client scripts (Ensure that java version >=
17):
```
# Run from root of the repo
- $ bin/kafka-console-producer.sh --topic test --bootstrap-server
localhost:9093 --producer.config
./docker/examples/fixtures/client-secrets/client-ssl.properties
+ # Note: In Kafka 4.2+, --command-config replaces the deprecated
--producer.config option.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
