AndrewJSchofield commented on code in PR #20479:
URL: https://github.com/apache/kafka/pull/20479#discussion_r2354710353
##########
docker/test/docker_sanity_test.py:
##########
@@ -155,15 +155,15 @@ def broker_restart_flow(self):
errors.append(constants.BROKER_RESTART_ERROR_PREFIX + str(e))
return errors
- producer_config = ["--bootstrap-server", "localhost:9092",
"--property", "client.id=host"]
+ producer_config = ["--bootstrap-server", "localhost:9092",
"--command-property", "client.id=host"]
Review Comment:
Strictly speaking, this was a mistake in the test before this PR :)
##########
docker/test/docker_sanity_test.py:
##########
@@ -155,15 +155,15 @@ def broker_restart_flow(self):
errors.append(constants.BROKER_RESTART_ERROR_PREFIX + str(e))
return errors
- producer_config = ["--bootstrap-server", "localhost:9092",
"--property", "client.id=host"]
+ producer_config = ["--bootstrap-server", "localhost:9092",
"--command-property", "client.id=host"]
self.produce_message(constants.BROKER_RESTART_TEST_TOPIC,
producer_config, "key", "message")
print("Stopping Container")
self.stop_container()
print("Resuming Container")
self.resume_container()
- consumer_config = ["--bootstrap-server", "localhost:9092",
"--property", "auto.offset.reset=earliest"]
+ consumer_config = ["--bootstrap-server", "localhost:9092",
"--command-property", "auto.offset.reset=earliest"]
Review Comment:
As was this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
