mjsax commented on code in PR #20570:
URL: https://github.com/apache/kafka/pull/20570#discussion_r2377287062
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##########
@@ -251,8 +251,6 @@ public void initializeStartupTasks(final TopologyMetadata
topologyMetadata,
);
try {
- task.initializeIfNeeded();
Review Comment:
I am not sure if we can remove this call? We actually get a lock on the
state directory here, so I am wondering if it's safe to _not_ get the lock?
But even more crucial: We also register the task on the `stateManager` (that
we created above), what is necessary to later access the state store (this code
is not written yet, because KIP-1035 is not fully implemented), because we
initialize (and open) the state store during registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
