Nikita-Shupletsov commented on code in PR #20570:
URL: https://github.com/apache/kafka/pull/20570#discussion_r2376382812
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##########
@@ -281,6 +281,15 @@ public void shouldPassMetrics(final String topologyType,
final String groupProto
streamsApplicationProperties = props(groupProtocol);
final Topology topology = topologyType.equals("simple") ?
simpleTopology(false) : complexTopology();
+ shouldPassMetrics(topology);
+
+ INTERCEPTING_CONSUMERS.clear();
+ INTERCEPTING_ADMIN_CLIENTS.clear();
+
+ shouldPassMetrics(topology);
Review Comment:
it does pretty much that: `Can we add a test that starts KS validates
metrics, stops and starts again validating all metrics?`
the new shouldPassMetrics starts KS and validates metrics.
so we call I call it twice to repeat the same action.
I updated the code a tad to avoid clearing the lists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
