chia7712 commented on code in PR #19513:
URL: https://github.com/apache/kafka/pull/19513#discussion_r2378273533
##########
gradlew:
##########
@@ -84,7 +86,7 @@ done
# shellcheck disable=SC2034
APP_BASE_NAME=${0##*/}
# Discard cd standard output in case $CDPATH is set
(https://github.com/gradle/gradle/issues/25036)
-APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit
+APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) ||
exit
Review Comment:
Excuse me, why to have those changes? Are those changed generated by gradle
9?
##########
build.gradle:
##########
@@ -3905,6 +3856,109 @@ project(':connect:test-plugins') {
}
}
+project(':distribution') {
+ base {
+ archivesName = "kafka_${versions.baseScala}"
+ }
+
+ configurations {
+ includeIntoDistribution
+ }
+
+ dependencies {
+ includeIntoDistribution project(path: ':core', configuration:
'releaseOnly')
+ includeIntoDistribution project(path: ':core', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':tools', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':trogdor', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':shell', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:api', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:runtime', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:transforms',
configuration: 'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:json', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:file', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:basic-auth-extension',
configuration: 'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:mirror', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':connect:mirror-client',
configuration: 'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':streams', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':streams:streams-scala',
configuration: 'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':streams:test-utils',
configuration: 'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':streams:examples', configuration:
'resolvedRuntimeClasspath')
+ includeIntoDistribution project(path: ':tools:tools-api', configuration:
'resolvedRuntimeClasspath')
+ }
+
+ task siteDocsTar(dependsOn: [':core:genProtocolErrorDocs',
':core:genProtocolTypesDocs', ':core:genProtocolApiKeyDocs',
':core:genProtocolMessageDocs',
+ ':core:genAdminClientConfigDocs',
':core:genProducerConfigDocs', ':core:genConsumerConfigDocs',
+ ':core:genKafkaConfigDocs',
':core:genTopicConfigDocs', ':core:genGroupConfigDocs',
+ ':connect:runtime:genConnectConfigDocs',
':connect:runtime:genConnectTransformationDocs',
+ ':connect:runtime:genConnectPredicateDocs',
+ ':connect:runtime:genSinkConnectorConfigDocs',
':connect:runtime:genSourceConnectorConfigDocs',
+ ':streams:genStreamsConfigDocs',
':core:genConsumerMetricsDocs', ':core:genProducerMetricsDocs',
+ ':connect:runtime:genConnectMetricsDocs',
':connect:runtime:genConnectOpenAPIDocs',
+ ':connect:mirror:genMirrorSourceConfigDocs',
':connect:mirror:genMirrorCheckpointConfigDocs',
+ ':connect:mirror:genMirrorHeartbeatConfigDocs',
':connect:mirror:genMirrorConnectorConfigDocs',
+ ':storage:genRemoteLogManagerConfigDoc',
':storage:genRemoteLogMetadataManagerConfigDoc'], type: Tar) {
+ archiveClassifier = 'site-docs'
+ compression = Compression.GZIP
+ from project.file("$rootDir/docs")
+ into 'site-docs'
+ destinationDirectory =
project(':core').layout.buildDirectory.dir('distributions')
+ duplicatesStrategy 'exclude'
+ preserveFileTimestamps = true
+ }
+
+ tasks.create(name: "releaseTarGz", dependsOn:
project(':core').configurations.archives.artifacts, type: Tar) {
+ into "kafka_${versions.baseScala}-${archiveVersion.get()}"
+ compression = Compression.GZIP
+ from(project.file("$rootDir/bin")) { into "bin/" }
+ from(project.file("$rootDir/config")) { into "config/" }
+ from(project.file("$rootDir/licenses")) { into "licenses/" }
+ from "$rootDir/LICENSE-binary" rename {String filename ->
filename.replace("-binary", "")}
+ from "$rootDir/NOTICE-binary" rename {String filename ->
filename.replace("-binary", "")}
+ from(project.siteDocsTar) { into("site-docs/") }
+ from(configurations.includeIntoDistribution) { into("libs/") }
+ from(project(':core').configurations.archives.artifacts.files) {
into("libs/") }
+ from(project(':tools').jar) { into("libs/") }
+ from(project(':trogdor').jar) { into("libs/") }
+ from(project(':shell').jar) { into("libs/") }
+ from(project(':connect:api').jar) { into("libs/") }
+ from(project(':connect:runtime').jar) { into("libs/") }
+ from(project(':connect:transforms').jar) { into("libs/") }
+ from(project(':connect:json').jar) { into("libs/") }
+ from(project(':connect:file').jar) { into("libs/") }
+ from(project(':connect:basic-auth-extension').jar) { into("libs/") }
+ from(project(':connect:mirror').jar) { into("libs/") }
+ from(project(':connect:mirror-client').jar) { into("libs/") }
+ from(project(':streams').jar) { into("libs/") }
+ from(project(':streams:streams-scala').jar) { into("libs/") }
+ from(project(':streams:test-utils').jar) { into("libs/") }
+ from(project(':streams:examples').jar) { into("libs/") }
+ from(project(':tools:tools-api').jar) { into("libs/") }
+ destinationDirectory =
project(':core').layout.buildDirectory.dir('distributions')
Review Comment:
Add a comment explaining that the value of `destination` is kept for
compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
