dejan2609 commented on PR #19513:
URL: https://github.com/apache/kafka/pull/19513#issuecomment-3358664101
I may have some good news for you @chia7712 !
Closing the gap on this issue: we will likely be able to drop Gradle helper
`:submodule` :crossed_fingers:
So, I just scrapped a skeleton POC solution #20625 with just two things:
- Gradle 8 -->> 9 upgrade
- `project(':tools:tools-api').configurations.runtimeClasspath` removed out
of `releaseTarGz` task
Results look encouraging: `releaseTarGz` task works fine (same goes for
`:jmh-benchmarks:shadowJar`) :white_check_mark:
Action points for me would be to reorganize all remaining commits into a new
solution (that keeps `releaseTarGz` task in `:core`) and perform some tests
(should be doable in a few days.).
If I may suggest something (my 2 cents on this): we could opt to solve
KAFKA-19750 separately (i.e. on a Gradle 8 level).
Rationale: it would be much easier to spot that single isolated change (and
revert it back if/when the time comes) rather than bundle it here.
But it's your call, let me know which option you prefer.
All-in-all: it is safe to say that things are wrapping up.
Stay tuned, we are so close :dart: :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
