chia7712 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2385458576
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
// Group coordinator configs
.define(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, LIST,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
- ConfigDef.ValidList.in(false,
Group.GroupType.documentValidValues()), MEDIUM,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
+
ConfigDef.ValidList.in(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED.toArray(new
String[0])),
Review Comment:
> I do understand your point but I was not expecting other group types to
use this config after KIP-848. It would be acceptable to me for share groups to
honour this config in trunk and AK 4.2. Let me know what you think.
In fact, I’d prefer to raise a KIP to deprecate
group.coordinator.rebalance.protocols in trunk and AK 4.2. Let’s leave it as
is, since extending a deprecated config would be a bit odd. I’ve opened
KAFKA-19740 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
