chia7712 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2388420219
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
// Group coordinator configs
.define(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, LIST,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
- ConfigDef.ValidList.in(false,
Group.GroupType.documentValidValues()), MEDIUM,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
Review Comment:
It should be `ConfigDef.ValidList.in(false,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED.toArray(new String[0]))`, right?
The empty `GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG` is illegal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
