jack2012aa opened a new pull request, #20619:
URL: https://github.com/apache/kafka/pull/20619

   # Description
   In kafka-features.sh, exclusive argument group of `--bootstrap-server` and 
`--bootstrap-controller` is required in the main parser, but `version-mapping` 
and `feature-dependencies` subcommands don't need the information.
   
   # Changes
   To avoid change in argument level, the exclusive group is not moved. It is 
now not required and only check for existence if the subcommand needs it.
   
   Since `FeatureCommand#mainNoExit` catches `ArgumentParserException`, 
`ArgumentParser#parseArgs` is used instead of `parseArgsOrFail`. It makes 
testing easier.
   
   Two tests are added. One tests whether not-remote subcommand can execute 
without bootstrap. Another tests whether remote subcommand cannot execute 
without bootstrap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to