jack2012aa commented on code in PR #20619:
URL: https://github.com/apache/kafka/pull/20619#discussion_r2408116907
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -92,14 +92,27 @@ static void execute(String... args) throws Exception {
addVersionMappingParser(subparsers);
addFeatureDependenciesParser(subparsers);
- Namespace namespace = parser.parseArgsOrFail(args);
+ Namespace namespace = parser.parseArgs(args);
String command = namespace.getString("command");
+ if (command.equals("version-mapping")) {
Review Comment:
The `version-mapping` and `feature-dependencies` subcommands don't use
`bootstrap-server` and `bootstrap-controller` arguments at all. The best
practice is to let these arguments be required arguments of other subcommands.
But I am not sure whether this change will require an KIP or worth one. Do you
have any suggestion?
Or, we can check whether user uses these arguments with `version-mapping`
and `feature-dependencies`, which makes the code more ugly but can provide user
more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
