chia7712 commented on code in PR #20248:
URL: https://github.com/apache/kafka/pull/20248#discussion_r2393983110
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -195,7 +190,7 @@ object StorageTool extends Logging {
): Unit = {
val releaseVersion =
Option(namespace.getString("release_version")).getOrElse(MetadataVersion.LATEST_PRODUCTION.toString)
try {
- val metadataVersion = MetadataVersion.fromVersionString(releaseVersion)
+ val metadataVersion = MetadataVersion.fromVersionString(releaseVersion,
true)
Review Comment:
> it may be inconsistent or confusing to the user
Perhaps the output could be adjusted to remind users that the version is not
for production. For example:
```
chia7712@fedora:~/project/kafka$ ./bin/kafka-storage.sh version-mapping
--release-version 4.2-IV1
WARNING: `4.2-IV1` is not production-ready
metadata.version=29 (4.2-IV1)
kraft.version=1
transaction.version=2
group.version=1
eligible.leader.replicas.version=1
share.version=1
streams.version=1
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
