chia7712 commented on code in PR #20248:
URL: https://github.com/apache/kafka/pull/20248#discussion_r2392339351
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -195,7 +190,7 @@ object StorageTool extends Logging {
): Unit = {
val releaseVersion =
Option(namespace.getString("release_version")).getOrElse(MetadataVersion.LATEST_PRODUCTION.toString)
try {
- val metadataVersion = MetadataVersion.fromVersionString(releaseVersion)
+ val metadataVersion = MetadataVersion.fromVersionString(releaseVersion,
true)
Review Comment:
> Why do we want the version mapping to succeed for version that they can't
format with.
Printing all versions is to be the same as the previous behavior
> Does this mean that they can ask the mapping for 4.2 but of course not
format for 4.2?
Users have the option to enable 4.2-IV format by configuring
`unstable.feature.versions.enable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
