chia7712 commented on code in PR #20725:
URL: https://github.com/apache/kafka/pull/20725#discussion_r2440809883
##########
core/src/test/java/kafka/server/share/ShareFetchUtilsTest.java:
##########
@@ -657,7 +657,7 @@ public Stream<? extends Arguments>
provideArguments(ExtensionContext context) th
private MemoryRecords createMemoryRecords(Map<Long, Integer>
recordsPerOffset) {
ByteBuffer buffer = ByteBuffer.allocate(1024);
- recordsPerOffset.forEach((offset, numOfRecords) ->
memoryRecordsBuilder(buffer, numOfRecords, offset).close());
+ recordsPerOffset.forEach((offset, numOfRecords) ->
memoryRecordsBuilder(buffer, offset, numOfRecords).close());
Review Comment:
```
public static MemoryRecordsBuilder memoryRecordsBuilder(ByteBuffer
buffer, int numOfRecords, long startOffset) {
MemoryRecordsBuilder builder = MemoryRecords.builder(buffer,
Compression.NONE,
TimestampType.CREATE_TIME, startOffset, 2);
for (int i = 0; i < numOfRecords; i++) {
builder.appendWithOffset(startOffset + i, 0L,
TestUtils.randomString(10).getBytes(), TestUtils.randomString(10).getBytes());
}
return builder;
}
```
ditto
##########
core/src/test/java/kafka/server/share/ShareFetchUtilsTest.java:
##########
@@ -636,7 +636,7 @@ public Stream<? extends Arguments>
provideArguments(ExtensionContext context) th
}
private MemoryRecords createMemoryRecords(long baseOffset, int
numRecords) {
- try (MemoryRecordsBuilder recordsBuilder =
memoryRecordsBuilder(numRecords, baseOffset)) {
+ try (MemoryRecordsBuilder recordsBuilder =
memoryRecordsBuilder(baseOffset, numRecords)) {
Review Comment:
```java
public static MemoryRecordsBuilder memoryRecordsBuilder(int
numOfRecords, long startOffset) {
return memoryRecordsBuilder(ByteBuffer.allocate(1024), numOfRecords,
startOffset);
}
```
it seems this change is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
