chia7712 commented on code in PR #20725:
URL: https://github.com/apache/kafka/pull/20725#discussion_r2442458170
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -7162,7 +7162,7 @@ public void testNextFetchOffsetWithMultipleConsumers() {
.withMaxInflightRecords(100)
.withState(SharePartitionState.ACTIVE)
.build();
- MemoryRecords records1 = memoryRecords(3, 0);
+ MemoryRecords records1 = memoryRecords(3);
String memberId1 = MEMBER_ID;
String memberId2 = "member-2";
Review Comment:
please take a look at line#7176
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -7562,21 +7562,21 @@ public void
testAcquireWhenBatchesAreRemovedFromBetweenInSubsequentFetchData() {
try (MemoryRecordsBuilder builder = MemoryRecords.builder(buffer,
Compression.NONE,
Review Comment:
line#7559 needs to be updated too
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -6796,7 +6796,7 @@ public void testCanAcquireRecordsReturnsTrue() {
assertEquals(0, sharePartition.startOffset());
Review Comment:
please check line#6769 - it has incorrect comment now
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -7208,7 +7208,7 @@ public void testReacquireSubsetWithAnotherMember() {
MemoryRecords records1 = memoryRecords(5, 5);
fetchAcquiredRecords(sharePartition, records1, 5);
- fetchAcquiredRecords(sharePartition, memoryRecords(12, 10), 12);
+ fetchAcquiredRecords(sharePartition, memoryRecords(10, 12), 12);
sharePartition.acknowledge(MEMBER_ID, List.of(
new ShareAcknowledgementBatch(5, 11, List.of((byte) 2)),
Review Comment:
please check line#7224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
