DL1231 commented on code in PR #20614:
URL: https://github.com/apache/kafka/pull/20614#discussion_r2422446247


##########
clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java:
##########
@@ -206,6 +211,19 @@ public Struct validate(Object item) {
         }
     }
 
+    @Override
+    public String typeName() {
+        return STRUCT_TYPE_NAME;
+    }
+
+    @Override
+    public String documentation() {
+        return "Represents a composite object or null. " +

Review Comment:
   Done.



##########
clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java:
##########
@@ -24,7 +26,10 @@
 /**
  * The schema for a compound record definition
  */
-public final class Schema extends Type {
+public final class Schema extends DocumentedType {
+
+    private static final String STRUCT_TYPE_NAME = "NULLABLE_STRUCT";

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to