DL1231 commented on code in PR #20614:
URL: https://github.com/apache/kafka/pull/20614#discussion_r2422448542
##########
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java:
##########
@@ -1116,7 +1116,8 @@ private static String toHtml() {
UINT16, UNSIGNED_INT32, VARINT, VARLONG, UUID, FLOAT64,
STRING, COMPACT_STRING, NULLABLE_STRING, COMPACT_NULLABLE_STRING,
BYTES, COMPACT_BYTES, NULLABLE_BYTES, COMPACT_NULLABLE_BYTES,
- RECORDS, COMPACT_RECORDS, new ArrayOf(STRING), new
CompactArrayOf(COMPACT_STRING)};
+ RECORDS, COMPACT_RECORDS, new ArrayOf(STRING), new
CompactArrayOf(COMPACT_STRING),
Review Comment:
> We need a way to make that clear.
Added a struct type to indecate whether the struct is nullable or not.
assignment => NULLABLE_STRUCT [topic_partitions] _tagged_fields
topic_partitions => STRUCT topic_id [partitions] _tagged_fields
topic_id => UUID
partitions => INT32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
