dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3333659984
> @dejan2609 It would be helpful to understand the reasoning behind the changes in this PR, since introducing unnecessary modifications is usually not a good idea. That’s why I left some questions on parts where I couldn’t see the motivation—for example: [#19513 (comment)](https://github.com/apache/kafka/pull/19513#discussion_r2378273533) > > Upgrading Gradle is an important task for Kafka, so I’d appreciate your help in clarifying the intent of this PR. Thanks! Yes, I understand the gravity of the situation. It goes without saying that these types of upgrades must be done with high caution. I have prior experience with upgrading Gradle major versions (from Gradle 6 to 7 and then from 7 to 8) and they were complicated enough (but both of those upgrades pale in comparison to this one). I left answers to both comments above, but I will sum it up here also: - first commit https://github.com/apache/kafka/commit/79f04159d96365d7b9c43c409134b1b1710e8c27 resolves bug KAFKA-19591 (on Gradle 8 level); objectively: this commit is a prerequisite for a Gradle 8 to 9 upgrade - all other commits are exclusively related to Gradle 8 to 9 upgrade I opted to keep separate commits for every phase just for the sake of clarity (and that was a good decision, I guess). Options to proceed: - option [1]: - merge commit https://github.com/apache/kafka/commit/79f04159d96365d7b9c43c409134b1b1710e8c27 (KAFKA-19591) into trunk separately - squash all other commits (related to Gradle 8 -->> 9 upgrade) into one and, after few days, merge that commit into trunk - option [2]: - put aside commit https://github.com/apache/kafka/commit/79f04159d96365d7b9c43c409134b1b1710e8c27 (KAFKA-19591) and try to concentrate only on Gradle 8 -->> 9 upgrade Note: not sure about the possibility of using option [2]: from where I see it https://github.com/apache/kafka/commit/79f04159d96365d7b9c43c409134b1b1710e8c27 (KAFKA-19591) is a must (either separately or as a part of upgrade). Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
