dejan2609 commented on PR #19513:
URL: https://github.com/apache/kafka/pull/19513#issuecomment-3370985553
@chia7712 Related to `// Add a trailing zero to the version if needed.`
:arrow_double_down:
___
The thing is that Gradle team aligned/consolidated tag names and version
numbers starting with version 9: now all tag names/versions have two dots (and
three digits):
https://github.com/apache/kafka/pull/20327#pullrequestreview-3131743127
So, my intention was to remove redundant check (rationale: if all versions
are the same there is no need to add a trailing zero :slightly_smiling_face:
and I assume it is highly unlikely that Gradle team will revert this decision).
LMK what you think: should we leave as-is in this PR or you want to be extra
cautious so I can fall back to trunk for this check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
