apoorvmittal10 commented on code in PR #20661:
URL: https://github.com/apache/kafka/pull/20661#discussion_r2414817911
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -524,17 +525,41 @@ public void handleResponse(PushTelemetryResponse
response) {
lock.writeLock().unlock();
}
}
+
+ private boolean isRetryable(final KafkaException maybeFatalException) {
Review Comment:
nit: Personally prefers to write private method after public methods hence I
would moved it later in the class. Feel free to ignore as that's my personal
preference for readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
