mjsax commented on code in PR #20661:
URL: https://github.com/apache/kafka/pull/20661#discussion_r2433978636
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -528,13 +529,13 @@ public void handleResponse(PushTelemetryResponse
response) {
@Override
public void
handleFailedGetTelemetrySubscriptionsRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the get telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
}
@Override
public void handleFailedPushTelemetryRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the push telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
Review Comment:
I agree. It's even an issue before this change, and I did raise this to
@apoorvmittal10 at some point in the past...
We get something like
```
org.apache.kafka.common.errors.UnsupportedVersionException: The node does
not support GET_TELEMETRY_SUBSCRIPTIONS
```
This come from
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java#L149
I always found it very annoying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
