ComingWen commented on code in PR #20402:
URL: https://github.com/apache/kafka/pull/20402#discussion_r2434429522
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java:
##########
@@ -271,16 +277,18 @@ public Date toType(Config config, Date orig) {
// This is a bit unusual, but allows the transformation config to be
passed to static anonymous classes to customize
// their behavior
private static class Config {
- Config(String field, String type, SimpleDateFormat format, String
unixPrecision) {
+ Config(String field, String type, SimpleDateFormat format, String
unixPrecision, String time_zone) {
Review Comment:
Adjusted the code based on feedback,please review again,thank you very much !
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java:
##########
@@ -271,16 +277,18 @@ public Date toType(Config config, Date orig) {
// This is a bit unusual, but allows the transformation config to be
passed to static anonymous classes to customize
// their behavior
private static class Config {
- Config(String field, String type, SimpleDateFormat format, String
unixPrecision) {
+ Config(String field, String type, SimpleDateFormat format, String
unixPrecision, String time_zone) {
this.field = field;
this.type = type;
this.format = format;
this.unixPrecision = unixPrecision;
+ this.time_zone= time_zone;
Review Comment:
Adjusted the code based on feedback,please review again,thank you very much !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]