ComingWen commented on code in PR #20402:
URL: https://github.com/apache/kafka/pull/20402#discussion_r2434429165
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java:
##########
@@ -83,7 +86,8 @@ public abstract class TimestampConverter<R extends
ConnectRecord<R>> implements
private static final String UNIX_PRECISION_NANOS = "nanoseconds";
private static final String UNIX_PRECISION_SECONDS = "seconds";
- private static final TimeZone UTC = TimeZone.getTimeZone("UTC");
+ private static TimeZone UTC = TimeZone.getTimeZone("UTC");
+ //private static final TimeZone UTC =
TimeZone.getTimeZone("Asia/Shanghai");
Review Comment:
Adjusted the code based on feedback，please review again，thank you very much ！
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java:
##########
@@ -92,6 +96,8 @@ public abstract class TimestampConverter<R extends
ConnectRecord<R>> implements
public static final ConfigDef CONFIG_DEF = new ConfigDef()
.define(FIELD_CONFIG, ConfigDef.Type.STRING, FIELD_DEFAULT,
ConfigDef.Importance.HIGH,
"The field containing the timestamp, or empty if the
entire value is a timestamp")
+ .define(TIMEZONE_CONFIG, ConfigDef.Type.STRING, TIMEZONE_DEFAULT,
ConfigDef.Importance.HIGH,
+ "The field containing the time_zone.")
Review Comment:
Adjusted the code based on feedback，please review again，thank you very much ！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
