JimmyWang6 commented on code in PR #20246:
URL: https://github.com/apache/kafka/pull/20246#discussion_r2413675601
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -746,7 +747,7 @@ public ShareAcquiredRecords acquire(
groupId, topicIdPartition);
// Do not send the lastOffsetToAcquire as when the subMap is
empty, it means that
// there isn't any overlap itself.
- ShareAcquiredRecords shareAcquiredRecords =
acquireNewBatchRecords(memberId, fetchPartitionData.records.batches(),
+ ShareAcquiredRecords shareAcquiredRecords =
acquireNewBatchRecords(memberId, acquireMode,
fetchPartitionData.records.batches(),
Review Comment:
Done. I have changed the acquire mode to `BATCH_OPTIMIZED/RECORD_LIMIT`
according to @AndrewJSchofield comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
