JimmyWang6 commented on code in PR #20246:
URL: https://github.com/apache/kafka/pull/20246#discussion_r2413683671
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -675,6 +675,9 @@ public ShareAcquiredRecords acquire(
FetchIsolation isolationLevel
) {
log.trace("Received acquire request for share partition: {}-{}
memberId: {}", groupId, topicIdPartition, memberId);
+ // Since the client side changes are not yet in place, use
BATCH_OPTIMIZED as the default AcquireMode.
+ ShareAcquireMode acquireMode =
acquireMode(ShareAcquireMode.BATCH_OPTIMIZED.toString());
+ boolean strict = ShareAcquireMode.STRICT.equals(acquireMode);
Review Comment:
@apoorvmittal10 Thank you for your comments. I have made the suggested
changes and added some more tests. Please take a look when you have time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
