majialoong commented on code in PR #20576:
URL: https://github.com/apache/kafka/pull/20576#discussion_r2373705548
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -206,20 +206,20 @@ public final class DistributedConfig extends WorkerConfig
{
public static final Long INTER_WORKER_KEY_SIZE_DEFAULT = null;
public static final String INTER_WORKER_KEY_TTL_MS_CONFIG =
"inter.worker.key.ttl.ms";
- public static final String INTER_WORKER_KEY_TTL_MS_MS_DOC = "The TTL of
generated session keys used for "
+ public static final String INTER_WORKER_KEY_TTL_MS_DOC = "The TTL of
generated session keys used for "
+ "internal request validation (in milliseconds)";
- public static final int INTER_WORKER_KEY_TTL_MS_MS_DEFAULT =
Math.toIntExact(TimeUnit.HOURS.toMillis(1));
+ public static final int INTER_WORKER_KEY_TTL_MS_DEFAULT =
Math.toIntExact(TimeUnit.HOURS.toMillis(1));
public static final String INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG =
"inter.worker.signature.algorithm";
public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT =
"HmacSHA256";
public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DOC = "The
algorithm used to sign internal requests"
- + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG + "'
will be used as a default on JVMs that support it; "
+ + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT +
"' will be used as a default on JVMs that support it; "
Review Comment:
I forgot to address this issue, thank you for pointing it out. I have now
resolved it and updated the latest results in the conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
