lucasbru commented on code in PR #20646:
URL: https://github.com/apache/kafka/pull/20646#discussion_r2413328546
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##########
@@ -258,6 +258,7 @@ private void removePartitionsForActiveTask(final TaskId
taskId) {
@Override
public synchronized void clear() {
+ pendingTasksToInit.clear();
Review Comment:
nit: Wouldn't it be less surprising if we'd also clear out
`pendingActiveTasksToCreate` and `pendingStandbyTasksToCreate`? I know it
doesn't affect the problematic code path, because they are not included in
`allTasks`. But it's weird that this code clears out only half the collections
in the data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
