chia7712 commented on code in PR #20759:
URL: https://github.com/apache/kafka/pull/20759#discussion_r2456033613
##########
clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java:
##########
@@ -134,4 +137,16 @@ public AbstractResponse getErrorResponse(int
throttleTimeMs, Throwable e) {
public static AlterConfigsRequest parse(Readable readable, short version) {
return new AlterConfigsRequest(new AlterConfigsRequestData(readable,
version), version);
}
+
+ // It is not safe to print all config values
+ @Override
+ public String toString() {
+ JsonNode json = AlterConfigsRequestDataJsonConverter.write(data,
version()).deepCopy();
Review Comment:
I left a comment in the email discussion thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
