showuon commented on code in PR #20759:
URL: https://github.com/apache/kafka/pull/20759#discussion_r2462684151
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -3081,7 +3082,19 @@ private AlterConfigsRequest
createAlterConfigsRequest(short version) {
configs.put(new ConfigResource(ConfigResource.Type.BROKER, "0"), new
AlterConfigsRequest.Config(configEntries));
configs.put(new ConfigResource(ConfigResource.Type.TOPIC, "topic"),
new AlterConfigsRequest.Config(emptyList()));
- return new AlterConfigsRequest.Builder(configs, false).build(version);
+ AlterConfigsRequest alterConfigsRequest = new
AlterConfigsRequest.Builder(configs, false).build(version);
+ assertEquals(
+ "AlterConfigsRequestData(resources=[" +
Review Comment:
Thanks @chia7712 ! LGTM!
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -3081,7 +3082,19 @@ private AlterConfigsRequest
createAlterConfigsRequest(short version) {
configs.put(new ConfigResource(ConfigResource.Type.BROKER, "0"), new
AlterConfigsRequest.Config(configEntries));
configs.put(new ConfigResource(ConfigResource.Type.TOPIC, "topic"),
new AlterConfigsRequest.Config(emptyList()));
- return new AlterConfigsRequest.Builder(configs, false).build(version);
+ AlterConfigsRequest alterConfigsRequest = new
AlterConfigsRequest.Builder(configs, false).build(version);
+ assertEquals(
+ "AlterConfigsRequestData(resources=[" +
Review Comment:
Thanks @chia7712 ! LGTM! Let's wait for the CI build result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
