jsancio commented on code in PR #20724:
URL: https://github.com/apache/kafka/pull/20724#discussion_r2465968541
##########
metadata/src/main/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetrics.java:
##########
@@ -67,17 +73,21 @@ public final class MetadataLoaderMetrics implements
AutoCloseable {
* test and we don't have one.
* @param batchProcessingTimeNsUpdater Updates the batch processing time
histogram.
* @param batchSizesUpdater Updates the batch sizes histogram.
+ * @param time The time object to use.
*/
public MetadataLoaderMetrics(
Optional<MetricsRegistry> registry,
Consumer<Long> batchProcessingTimeNsUpdater,
Consumer<Integer> batchSizesUpdater,
- AtomicReference<MetadataProvenance> lastAppliedProvenance
+ AtomicReference<MetadataProvenance> lastAppliedProvenance,
+ Time time
Review Comment:
Minor but this module tends order `Time` as one of first few parameters. How
about:
```java
public MetadataLoaderMetrics(
Time time,
Optional<MetricsRegistry> registry,
...
) {
```
##########
docs/upgrade.html:
##########
@@ -190,8 +190,8 @@ <h5><a id="upgrade_420_notable"
href="#upgrade_420_notable">Notable changes in 4
For further details, please refer to <a
href="https://cwiki.apache.org/confluence/x/6oqMEw";>KIP-1100</a>.
</li>
<li>
- A new metric <code>AvgIdleRatio</code> has been added to the
<code>ControllerEventManager</code> group. This metric measures the average
idle ratio of the controller event queue thread,
- providing visibility into how much time the controller spends waiting
for events versus processing them. The metric value ranges from 0.0 (always
busy) to 1.0 (always idle).
+ A new metric <code>AvgIdleRatio</code> has been added to the
<code>ControllerEventManager</code> and <code>MetadataLoader</code> groups.
This metric measures the average idle ratio of their respective event queue
threads,
Review Comment:
Type. "These metrics measure" instead of "This metric measures".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
