MahsaSeifikar commented on code in PR #20724:
URL: https://github.com/apache/kafka/pull/20724#discussion_r2466020837
##########
metadata/src/main/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetrics.java:
##########
@@ -67,17 +73,21 @@ public final class MetadataLoaderMetrics implements
AutoCloseable {
* test and we don't have one.
* @param batchProcessingTimeNsUpdater Updates the batch processing time
histogram.
* @param batchSizesUpdater Updates the batch sizes histogram.
+ * @param time The time object to use.
*/
public MetadataLoaderMetrics(
Optional<MetricsRegistry> registry,
Consumer<Long> batchProcessingTimeNsUpdater,
Consumer<Integer> batchSizesUpdater,
- AtomicReference<MetadataProvenance> lastAppliedProvenance
+ AtomicReference<MetadataProvenance> lastAppliedProvenance,
+ Time time
Review Comment:
We can modify this as follows to maintain the same order as in
`QuorumControllerMetrics`.
```
public MetadataLoaderMetrics(
Optional<MetricsRegistry> registry,
Time time,
...
) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
