adixitconfluent commented on code in PR #20819: URL: https://github.com/apache/kafka/pull/20819#discussion_r2491493767
########## clients/src/main/java/org/apache/kafka/common/requests/ShareRequestMetadata.java: ########## Review Comment: `ShareRequestMetadata` is utilized in the client at multiple places such as `ShareFetchRequest.java`, `ShareSessionHandler.java` and `ShareAcknowledgeRequest.java` because memberId is treated as Uuid there, hence I did not touch this class. Besides, all the functionalities of `ShareRequestMetadata` that are utilized in the broker are static in nature, hence I got rid of it in the broker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
