adixitconfluent commented on code in PR #20819:
URL: https://github.com/apache/kafka/pull/20819#discussion_r2494689785
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -357,11 +356,10 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
String memberId
) {
log.trace("Release session request for groupId: {}, memberId: {}",
groupId, memberId);
- Uuid memberIdUuid = Uuid.fromString(memberId);
List<TopicIdPartition> topicIdPartitions =
cachedTopicIdPartitionsInShareSession(
- groupId, memberIdUuid);
+ groupId, memberId);
Review Comment:
The javadoc corresponding to both methods `releaseSession` and
`cachedTopicIdPartitionsInShareSession` are already correct. Am I missing
something?
relaseSession javadoc
```
/**
* The release session method is used to release the session for the
memberId of respective group.
* The method post removing session also releases acquired records for
the respective member.
* The method returns a future that will be completed with the release
response.
*
* @param groupId The group id, this is used to identify the share group.
* @param memberId The member id, generated by the group-coordinator,
this is used to identify the client.
*
* @return A future that will be completed with the release response.
*/
```
cachedTopicIdPartitionsInShareSession javadoc
```
/**
* The cachedTopicIdPartitionsInShareSession method is used to get the
cached topic-partitions in the share session.
*
* @param groupId The group id in the share fetch request.
* @param memberId The member id in the share fetch request.
*
* @return The list of cached topic-partitions in the share session if
present, otherwise an empty list.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
