gensericghiro commented on code in PR #20766:
URL: https://github.com/apache/kafka/pull/20766#discussion_r2492174204
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##########
@@ -284,6 +288,7 @@ public Map<String, String> clientLevelTagMap() {
final Map<String, String> tagMap = new LinkedHashMap<>();
tagMap.put(CLIENT_ID_TAG, clientId);
tagMap.put(PROCESS_ID_TAG, processId);
+ tagMap.put(APPLICATION_ID_TAG, applicationId);
Review Comment:
You're right, good catch. It doesn't seem like I can add a tag for a
specific metric however. Since `addClientStateTelemetryMetric` is calling the
generic `addClientLevelMutableMetric` method, where tags get added, we'd need
to add conditional logic there, which I don't think is something we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
