coltmcnealy-lh commented on PR #20833: URL: https://github.com/apache/kafka/pull/20833#issuecomment-3493942298
> In an internal PR [here](https://github.com/littlehorse-enterprises/kafka/pull/11), it was advised that I should handle `TaskMigratedException`. However, I'm not sure the best way to do that. Could anyone who knows this code better advise please? I will poke around but would appreciate help. > > Thanks @eduwercamacaro for pointing that out! @eduwercamacaro I looked further into the code of `StreamThread.java`. It turns out that there isn't any special exception handling done in the `runOnceWithProcessingThreads()` nor the `runOnceWithoutProcessingThreads()` when they call `maybeCommit()` which calls `TaskManager#commit()`. The `TaskMigratedException` is handled further up the stack. That is great news, because any `TaskMigratedException`s thrown by where I call `TaskManager#commit()` would be handled by the same place that those exceptions are handled. @mjsax would you mind confirming this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
