mjsax commented on code in PR #20833:
URL: https://github.com/apache/kafka/pull/20833#discussion_r2507373469
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -1458,6 +1458,14 @@ protected boolean maybeUpdateSubscriptionVersion(final
int receivedAssignmentMet
@Override
public void onAssignment(final Assignment assignment, final
ConsumerGroupMetadata metadata) {
+ final Set<Task> tasksWithOpenTransactions = taskManager.allOwnedTasks()
+ .values()
+ .stream()
+ .filter(t -> t.commitNeeded())
+ .collect(Collectors.toSet());
+ log.info("Committing {} tasks with open transactions before
onAssignment()", tasksWithOpenTransactions.size());
+ taskManager.commit(tasksWithOpenTransactions);
Review Comment:
I believe it messes up the rebalancing and might not just cleanly bubble up
to `poll()`. \cc @lianetm to confirm.
I know for sure, that we have error handling logic inside
`StreamsRebalanceListener#onPartitionsRevoked()`, to avoid throwing any
exception from the handler back into the consumer. I assume it's the same for
the partition assignor at hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
