mjsax commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2496655306
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -772,7 +773,7 @@ private StateUpdater.RemovedTaskResult waitForFuture(final
TaskId taskId,
final
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
final StateUpdater.RemovedTaskResult removedTaskResult;
try {
- removedTaskResult = future.get();
+ removedTaskResult = future.get(1, TimeUnit.MINUTES);
Review Comment:
Do I understand correctly, that this is the core fix, to avoid blocking
forever?
(Plus the additional cleanup code add to `shutdownStateUpdater` in case we
really hit the timeout here?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
