Nikita-Shupletsov commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2497834564
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -772,7 +773,7 @@ private StateUpdater.RemovedTaskResult waitForFuture(final
TaskId taskId,
final
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
final StateUpdater.RemovedTaskResult removedTaskResult;
try {
- removedTaskResult = future.get();
+ removedTaskResult = future.get(1, TimeUnit.MINUTES);
Review Comment:
the core fix is the error handling. my idea is to never let the state
updated thread die if we get a StreamsException. if we don't die and handle
them correctly, we will not need to worry about hanging here.
I added a timeout here just an extra layer of protection. that's why I added
BUG_ERROR_MESSAGE to the log message, because I don't think we should expect it
ever happen under normal circumstances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
