AndrewJSchofield commented on code in PR #20837:
URL: https://github.com/apache/kafka/pull/20837#discussion_r2511365404
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -150,6 +150,12 @@ enum SharePartitionState {
AcknowledgeType.REJECT.id, RecordState.ARCHIVED
);
+ /**
+ * Records whose delivery count exceeds this are deemed abnormal,
+ * and the batching of these records should be reduced.
+ */
+ private static final int BAD_RECORD_DELIVERY_THRESHOLD = 3;
Review Comment:
The configured delivery count limit can range from 2 to 10 inclusive. If the
configured value is 2, we need to set the threshold as 2. If the configured
value is larger, maybe half of the configured value would be a good threshold.
So, for config=5, use 3 (default). For config=10, use 5. And so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
