adixitconfluent commented on code in PR #20837:
URL: https://github.com/apache/kafka/pull/20837#discussion_r2533206008
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -362,6 +367,7 @@ enum SharePartitionState {
this.leaderEpoch = leaderEpoch;
this.maxInFlightRecords = maxInFlightRecords;
this.maxDeliveryCount = maxDeliveryCount;
+ this.badRecordDeliveryThreshold = (int) Math.ceil((double)
maxDeliveryCount / 2);
Review Comment:
> If the configured value is 2, we need to set the threshold as 2.
I was going by Andrew's comment. Not sure if we want to have this
improvement if delivery count is set to 2. I do agree with your point that the
improved logic won't work for delivery count 2 if such enhancement is made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
