Nikita-Shupletsov commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2520746822
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1592,10 +1603,16 @@ private void shutdownStateUpdater() {
for (final Task task : tasksToCloseDirty) {
closeTaskDirty(task, false);
}
+ // Handling all failures that occurred during the remove process
for (final StateUpdater.ExceptionAndTask exceptionAndTask :
stateUpdater.drainExceptionsAndFailedTasks()) {
Review Comment:
it's possible that the remove task fails. then we will get them here. I
added the comment above that sort of explains that to make it less confusing in
the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
