lucasbru commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2523177299


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -772,7 +773,7 @@ private StateUpdater.RemovedTaskResult waitForFuture(final 
TaskId taskId,
                                                          final 
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
         final StateUpdater.RemovedTaskResult removedTaskResult;
         try {
-            removedTaskResult = future.get();
+            removedTaskResult = future.get(1, TimeUnit.MINUTES);

Review Comment:
   Yes, this is not only called during close, but also for rebalances, for 
example. If the state updater is super slow, we could run into this, and the 
error message will indicate a bug when this could actually be caused by 
infrastructure / overloading. We already saw cases where state updater is 
blocked for 20s...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to