mjsax commented on code in PR #20883:
URL: https://github.com/apache/kafka/pull/20883#discussion_r2529200507
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##########
@@ -199,7 +193,16 @@ public <T> void addClientLevelImmutableMetric(final String
name,
final String description,
final RecordingLevel
recordingLevel,
final T value) {
- final MetricName metricName = metrics.metricName(name,
CLIENT_LEVEL_GROUP, description, clientLevelTagMap());
+ addClientLevelImmutableMetric(name, description,
Collections.emptyMap(), recordingLevel, value);
+ }
+
+ public <T> void addClientLevelImmutableMetric(final String name,
+ final String description,
+ final Map<String, String>
additionalTags,
+ final RecordingLevel
recordingLevel,
+ final T value) {
+ final MetricName metricName = metrics.metricName(name,
CLIENT_LEVEL_GROUP, description,
+ clientLevelTagMap(additionalTags));
Review Comment:
No that I know of (and 100 would be very tight). As long as checkstyle does
not complain, we are good.
The other point is: if we really have too many parameter, the current
formatting with a single line break is also very hard to read, and if we thing
the line gets to long, we should go with a single-parameter per line formatting:
```
final MetricName metricName = metrics.metricName(
name,
CLIENT_LEVEL_GROUP,
description,
clientLevelTagMap(additionalTags)
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
