gensericghiro opened a new pull request, #20906:
URL: https://github.com/apache/kafka/pull/20906

   ## Summary
   When working on
   
[KIP-1091](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics),
   we mistakenly applied the `process-id` tag to all client-level metrics,
   rather than just the `client-state`, `thread-state`, and
   `recording-level` metrics as specified in the KIP. This issue came to
   light while working on KIP-1221, which aimed to add the `application-id`
   as a tag to the `client-state` metric introduced by KIP-1091. This PR
   removes these tags from all metrics by default, and adds them to only
   the `client-state` (application-id + process-id) and the
   `recording-level` (process-id only)
   
   ## Tests
   Unit tests in `ClientMetricsTest.java` and `StreamsMetricsImplTest.java`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to