artemlivshits commented on code in PR #20882:
URL: https://github.com/apache/kafka/pull/20882#discussion_r2529284450
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1780,6 +1782,8 @@ class KafkaApis(val requestChannel: RequestChannel,
}
val controlRecords = mutable.Map.empty[TopicIdPartition, MemoryRecords]
+ val markerTransactionVersion = marker.transactionVersion()
+
Review Comment:
You're right it wouldn't work, at this level we're checking and updating the
same epoch. But we do need to address groupCoordinator.completeTransaction
code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
