jolshan commented on code in PR #20882:
URL: https://github.com/apache/kafka/pull/20882#discussion_r2534871796


##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -3418,6 +3425,103 @@ class KafkaApisTest extends Logging {
     assertEquals(normalize(expectedResponse), normalize(response.data))
   }
 
+  @ParameterizedTest(name = "testWriteTxnMarkersEpochValidationError with 
transactionVersion={0}")
+  @ValueSource(shorts = Array(1, 2))
+  def testWriteTxnMarkersEpochValidationError(transactionVersion: Short): Unit 
= {
+    // Test that epoch validation errors (InvalidProducerEpochException) are 
properly
+    // propagated through KafkaApis -> ReplicaManager -> Partition -> 
UnifiedLog

Review Comment:
   Does this test really go through all these layers? It seems like we just 
mock ReplicaManager right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to