kirktrue commented on code in PR #20324: URL: https://github.com/apache/kafka/pull/20324#discussion_r2548073098
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PositionsValidator.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals; + +import org.apache.kafka.clients.ApiVersions; +import org.apache.kafka.clients.consumer.Consumer; +import org.apache.kafka.clients.consumer.internals.events.AsyncPollEvent; +import org.apache.kafka.clients.consumer.internals.events.CheckAndUpdatePositionsEvent; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.utils.LogContext; +import org.apache.kafka.common.utils.Time; + +import org.slf4j.Logger; + +import java.time.Duration; +import java.util.Map; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicReference; + +import static java.util.Objects.requireNonNull; + +/** + * As named, this class validates positions in the {@link SubscriptionState} based on current {@link ConsumerMetadata} + * version. It maintains just enough shared state to determine when it can avoid costly inter-thread communication + * in the {@link Consumer#poll(Duration)} method. + * + * <p/> + * + * Callers from the application thread should not mutate any of the state contained within this class. + * It should be considered as <em>read-only</em>, and only the background thread should mutate the state. + */ +public class PositionsValidator { + + private final Logger log; + private final Time time; + private final ConsumerMetadata metadata; + private final SubscriptionState subscriptions; + + /** + * Exception that occurred while validating positions, that will be propagated on the next + * call to validate positions. This could be an error received in the + * OffsetsForLeaderEpoch response, or a LogTruncationException detected when using a + * successful response to validate the positions. It will be cleared when thrown. + */ + private final AtomicReference<RuntimeException> cachedValidatePositionsException = new AtomicReference<>(); + + private final AtomicInteger metadataUpdateVersion = new AtomicInteger(-1); + + public PositionsValidator(LogContext logContext, + Time time, + ConsumerMetadata metadata, + SubscriptionState subscriptions) { + this.log = requireNonNull(logContext).logger(getClass()); + this.time = requireNonNull(time); + this.metadata = requireNonNull(metadata); + this.subscriptions = requireNonNull(subscriptions); + } + + /** + * This method is called by the background thread in response to {@link AsyncPollEvent} and + * {@link CheckAndUpdatePositionsEvent}. + */ + Map<TopicPartition, SubscriptionState.FetchPosition> getPartitionsToValidate(ApiVersions apiVersions) { Review Comment: Renamed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
