junrao commented on code in PR #20844:
URL: https://github.com/apache/kafka/pull/20844#discussion_r2550548677
##########
docs/upgrade.html:
##########
@@ -137,11 +137,14 @@ <h5><a id="upgrade_420_notable"
href="#upgrade_420_notable">Notable changes in 4
<li>
LIST-type configurations now enforce stricter validation:
<ul>
- <li>Null values are no longer accepted for most LIST-type
configurations, except those that explicitly
- allow a null default value or where a null value has a
well-defined semantic meaning.</li>
- <li>Duplicate entries within the same list are no longer
permitted.</li>
- <li>Empty lists are no longer allowed, except in
configurations where an empty list has a well-defined
- semantic meaning.</li>
+ <li>Null values are no longer accepted for most LIST-type
configurations. Exceptions apply only to
+ configurations that have null as their default value,
as users cannot explicitly assign null values
Review Comment:
I was wondering if the config value can be null when
AlterConfigOp.OpType.SET is used. It seems that this is disallowed in
ConfigAdminManager.
```
if (!nullUpdates.isEmpty) {
throw new InvalidRequestException("Null value not supported for
: " +
String.join(", ", nullUpdates))
}
```
So by enforcing non-null at the config level, we are not introducing any
breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
