squah-confluent commented on code in PR #21013:
URL: https://github.com/apache/kafka/pull/21013#discussion_r2580486043
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -21009,6 +21009,90 @@ fooTopicName, computeTopicHash(fooTopicName,
metadataImage)
tasks
);
}
+
+ @Test
+ public void testConsumerGroupMemberJoinsWithNonEmptyRegexToEmptyRegex() {
Review Comment:
Could we rename this to `testConsumerGroupMemberClearsRegex` and move it
after `testConsumerGroupMemberJoinRefreshesExpiredRegexes`?
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -21009,6 +21009,90 @@ fooTopicName, computeTopicHash(fooTopicName,
metadataImage)
tasks
);
}
+
+ @Test
+ public void testConsumerGroupMemberJoinsWithNonEmptyRegexToEmptyRegex() {
+ String groupId = "fooup";
+ String memberId1 = Uuid.randomUuid().toString();
+
+ Uuid fooTopicId = Uuid.randomUuid();
+ String fooTopicName = "foo";
+ Uuid barTopicId = Uuid.randomUuid();
+ String barTopicName = "bar";
Review Comment:
Is `bar` used anywhere? We could remove it if not.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3307,13 +3307,16 @@ private UpdateRegularExpressionsResult
maybeUpdateRegularExpressions(
// We also trigger a refresh of the regexes in order to
resolve it.
throwIfRegularExpressionIsInvalid(updatedMember.subscribedTopicRegex());
requireRefresh = true;
+
Review Comment:
nit: Could we revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
